Fix ListView selection and cursor rendering (regressions from Stage 2)

You were right that selecting a line looked off. Three separate problems, two
of them introduced by the Stage 2 dark-mode block:

1. The selection band was ERASED in dark mode. Stage 2 restated the dark
   surface on `table > tbody > tr > *`, i.e. on the CELLS — but 7.css paints
   tr.highlighted on the ROW, and a cell background paints over a row
   background. The selected row kept only its 1px border and no fill. The base
   surface now goes on `table` alone; cells stay transparent so the row band
   shows through. Same trap re-applies to the cell separators, which 7.css
   deliberately drops inside a selected row and the dark rule was re-adding.

2. The cursor rectangle was drawn PER CELL. `tr.is-cursor > *` puts a dotted
   outline around every cell, so the focused row rendered as a row of dotted
   boxes. Win7 drew one rectangle around the row — the outline belongs on the
   `tr`.

3. Selection was barely visible even in light, and that one is 7.css's own
   semantics rather than a bug: listview's `.highlighted` is Win7's *inactive*
   selection, a near-white wash. Win7 drew the FOCUSED pane's selection as the
   stronger Aero band. The table now carries `is-active` from the panel's own
   isActive(), and the focused pane's selection uses --w7-el-grad-h/-bd-h,
   which the dark palette already restates, so it recolours for free.

Verified by cropping and zooming the harness screenshots in both themes rather
than eyeballing a full page: full-row band, separators dropped inside it, and a
single dotted rectangle on the cursor row.

Co-Authored-By: Claude <noreply@anthropic.com>

This commit is contained in:

jgamboa

2026-08-16 02:00:30 +02:00

co-authored by

Claude

parent 11c3d419c7

commit 4102020f5c

3 changed files with 33 additions and 11 deletions

									
										ui/dev/harness.html
									
		+2
		-2
	
												View File
												
				@@ -91,8 +91,8 @@

				        </table>

				      </figure>

				      <figure class="cell" style="margin:0">

				        <figcaption>ours — file-panel.html (selected + cursor row)</figcaption>

				        <table>

				        <figcaption>ours — focused panel (is-active): selected + cursor</figcaption>

				        <table class="is-active">

				          <colgroup>

				            <col />

				            <col style="width: 5.5rem" />